phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Mon, 11 Apr 2016 21:37:32 GMT
Github user samarthjain commented on the pull request:

    https://github.com/apache/phoenix/pull/153#issuecomment-208573524
  
    @ankitsinghal - thanks for adding the upgrade util test. I have a question/suggestion:
we should probably disallow users to execute create and use schema statements if the name
space feature isn't enabled. I see that you are currently failing the upgrade if the name
space feature isn't enabled which is good. To be consistent we should do the same for create
and use schema statements. Another thing to think would be whether we should allow setting
schema property on connection if name space feature is disabled. I lean towards not allowing
it. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message