phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Fri, 08 Apr 2016 20:08:18 GMT
Github user chrajeshbabu commented on the pull request:

    https://github.com/apache/phoenix/pull/156#issuecomment-207582047
  
    @JamesRTaylor  Thanks for the review. Committed the changes handling the review comments.
    Refactored the code and added code comments where ever possible. 
    
    Now not handling the special cases required for ChunkedResultItertor. 
    
    bq. Another potential, different approach would be for Phoenix to universally handle the
split during scan case (rather than letting the HBase client scanner handle it for non aggregate
case and Phoenix handle it for the aggregate case). Would that simplify things?
    Now throwing stale region bound exception all the cases when ever we get NSRE then phoenix
client can handle the NSRE than hbase client handling with wrong region boundaries.
    
    The ordered aggregate queries issue you are mentioning can be handled as part of other
issue.
    
    Please review the latest code.
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message