phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Fri, 08 Apr 2016 19:35:01 GMT
Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r59077866
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
    @@ -402,8 +405,8 @@ private RegionScanner scanUnordered(ObserverContext<RegionCoprocessorEnvironment
                 }
     
                 Region region = c.getEnvironment().getRegion();
    -            region.startRegionOperation();
                 try {
    +                region.startRegionOperation();
    --- End diff --
    
    Currently changed the code to throw stale region exception all when we get NSRE because
hbase client may recreate the scanners with wrong region boundaries on NSRE. I have handling
this in BaseScannerRegionObserver so need not handle in all observers. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message