phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Fri, 08 Apr 2016 19:30:43 GMT
Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r59077319
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
    @@ -279,6 +301,31 @@ protected RegionScanner getWrappedScanner(final ObserverContext<RegionCoprocesso
                 final ImmutableBytesWritable ptr) {
             return new RegionScanner() {
     
    +            private boolean hasReferences = checkForReferenceFiles();
    +            private HRegionInfo regionInfo = c.getEnvironment().getRegionInfo();
    +            private byte[] actualStartKey = getActualStartKey();
    +
    +            private boolean checkForReferenceFiles(){
    --- End diff --
    
    Added the code comments and checking references is not expensive. We need to do this for
local indexes case only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message