phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Fri, 08 Apr 2016 08:07:43 GMT
Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r58992390
  
    --- Diff: phoenix-core/src/main/java/org/apache/hadoop/hbase/ipc/controller/MetadataRpcController.java
---
    @@ -36,7 +37,16 @@
     			.add(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME)
     			.add(PhoenixDatabaseMetaData.SYSTEM_STATS_NAME)
     			.add(PhoenixDatabaseMetaData.SYSTEM_SEQUENCE_NAME)
    -			.add(PhoenixDatabaseMetaData.SYSTEM_FUNCTION_NAME).build();
    +			.add(PhoenixDatabaseMetaData.SYSTEM_FUNCTION_NAME)
    +            .add(SchemaUtil.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES,
true)
    --- End diff --
    
    yeah, namespace mapping for system tables will not always be true as it is controlled
with phoenix.connection.mapSystemTablesToNamespace, 
    but this is just the list of system tables, so it includes SYSTEM.CATAOG and SYSTEM:CATALOG
both to set the priority for RPC accordingly. 
    do you think, it could have any impact?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message