phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Fri, 08 Apr 2016 07:45:53 GMT
Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r58990540
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableKey.java ---
    @@ -26,7 +28,8 @@
         public PTableKey(PName tenantId, String name) {
             Preconditions.checkNotNull(name);
             this.tenantId = tenantId;
    -        this.name = name;
    +        this.name = !name.contains(QueryConstants.NAMESPACE_SEPARATOR) ? name
    --- End diff --
    
    So if the table name was A:B, the key would become A.B. Can you add some test case around
this and make sure creating, query, upserting to a table named like this works fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message