phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...
Date Thu, 07 Apr 2016 16:30:13 GMT
Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/158#discussion_r58902347
  
    --- Diff: phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java
---
    @@ -19,19 +19,26 @@
     
     import static org.junit.Assert.assertTrue;
     import static org.junit.Assert.fail;
    +import static org.mockito.Matchers.anyLong;
    +import static org.mockito.Mockito.atLeastOnce;
    +import static org.mockito.Mockito.spy;
     
    +import com.google.common.base.Stopwatch;
    --- End diff --
    
    Don't use the guava StopWatch here. We have run into conflicts before because of mismatches
in guava versions. You can use the PhoenixStopWatch class here instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message