phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Wed, 06 Apr 2016 14:32:05 GMT
Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r58715199
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
    @@ -265,12 +332,18 @@ public SingleTableColumnResolver(PhoenixConnection connection, NamedTableNode
ta
                    if (def.getColumnDefName().getFamilyName() != null) {
                        families.add(new PColumnFamilyImpl(PNameFactory.newName(def.getColumnDefName().getFamilyName()),Collections.<PColumn>emptyList()));
                    }
    -           }
    -           Long scn = connection.getSCN();
    -           PTable theTable = new PTableImpl(connection.getTenantId(), table.getName().getSchemaName(),
table.getName().getTableName(), scn == null ? HConstants.LATEST_TIMESTAMP : scn, families);
    +            }
    +            Long scn = connection.getSCN();
    +            String schema = table.getName().getSchemaName();
    +            if (connection.getSchema() != null) {
    --- End diff --
    
    Actually, when the schema for the table{T} is not present, we try to resolve table with
connection schema {<connection_schema>.T} if set in connection.
    I have added a test case UseSchemaIT#testMappedView, is it you are expecting? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message