phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Wed, 06 Apr 2016 01:26:31 GMT
Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58640276
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
    @@ -121,8 +170,21 @@ public synchronized void initScanner() throws SQLException {
                     this.scanIterator =
                             new ScanningResultIterator(htable.getScanner(scan), scanMetrics);
                 } catch (IOException e) {
    -                Closeables.closeQuietly(htable);
    -                throw ServerUtil.parseServerException(e);
    +                if(handleSplitRegionBoundaryFailureDuringInitialization) {
    --- End diff --
    
    This is required for ChunkedResultIterator if we are going to deprecate or not use it
we don't need these changes. Other than that we might need to deal with it in PhoenixRecordReader(currently
we skipping range check but for local indexes it's compulsory to handle otherwise we might
miss one of the daughter records)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message