phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Wed, 06 Apr 2016 01:19:58 GMT
Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58639845
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
    @@ -80,13 +94,19 @@
         };
     
     
    -    public TableResultIterator(MutationState mutationState, TableRef tableRef, Scan scan,
CombinableMetric scanMetrics, long renewLeaseThreshold) throws SQLException {
    +    public TableResultIterator(MutationState mutationState, Scan scan, CombinableMetric
scanMetrics, long renewLeaseThreshold, QueryPlan plan) throws SQLException {
    +        this(mutationState, scan, scanMetrics, renewLeaseThreshold, plan, false);
    +    }
    +
    +    public TableResultIterator(MutationState mutationState, Scan scan, CombinableMetric
scanMetrics, long renewLeaseThreshold, QueryPlan plan, boolean handleSplitRegionBoundaryFailureDuringInitialization)
throws SQLException {
             this.scan = scan;
             this.scanMetrics = scanMetrics;
    -        PTable table = tableRef.getTable();
    +        PTable table = plan.getTableRef().getTable();
             htable = mutationState.getHTable(table);
             this.scanIterator = UNINITIALIZED_SCANNER;
             this.renewLeaseThreshold = renewLeaseThreshold;
    +        this.plan = plan;
    +        this.handleSplitRegionBoundaryFailureDuringInitialization = handleSplitRegionBoundaryFailureDuringInitialization;
    --- End diff --
    
    handleSplitRegionBoundaryFailureDuringInitialization will be true for scanning intermediate
chunks in ChunkedResultIterator. When we create scanner for new chunk we might see stale region
boundaries in that case also we need to forcibly recreate the iterator with new boundaries.
In normal case if we get StaleRegionBoundary exception while creating scanner BaseResultIterator
handles it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message