phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrajeshbabu <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Tue, 05 Apr 2016 23:39:49 GMT
Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58632305
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
    @@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final byte[] originalStartKey,
final byte[]
             if (scanStopKey.length > 0 && Bytes.compareTo(scanStartKey, scanStopKey)
>= 0) { 
                 return null; 
             }
    -        newScan.setAttribute(SCAN_ACTUAL_START_ROW, scanStartKey);
    -        newScan.setStartRow(scanStartKey);
    -        newScan.setStopRow(scanStopKey);
    +        if(ScanUtil.isLocalIndex(scan)) {
    --- End diff --
    
    @JamesRTaylor  we cannot use keyoffset > 0 check always for considering local indexes
scan because in special case like if a table has only one region then region start key length
and end key length is zero so keyoffset also becoming zero. In that case we need to check
local index scan or not to set the attributes properly. Wdyt? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message