phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Tue, 05 Apr 2016 03:47:39 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58483341
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
    @@ -465,7 +465,14 @@ private static String toString(List<byte[]> gps) {
         }
     
         private List<List<Scan>> getParallelScans() throws SQLException {
    -        return getParallelScans(EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
    +        if (scan == null
    +                || (ScanUtil.isLocalIndex(scan)
    +                        && Bytes.compareTo(context.getScan().getStartRow(), scan.getStartRow())
== 0 && Bytes
    +                        .compareTo(context.getScan().getStopRow(), scan.getStopRow())
== 0)) {
    +            return getParallelScans(EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY);
    --- End diff --
    
    This seems strange - why do we call getParallelScans with empty byte arrays in this case?
Please document.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message