phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Tue, 05 Apr 2016 03:45:38 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58483244
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
    @@ -326,11 +325,12 @@ private static void optimizeProjection(StatementContext context,
Scan scan, PTab
             }
         }
         
    -    public BaseResultIterators(QueryPlan plan, Integer perScanLimit, ParallelScanGrouper
scanGrouper) throws SQLException {
    +    public BaseResultIterators(QueryPlan plan, Integer perScanLimit, ParallelScanGrouper
scanGrouper, Scan scan) throws SQLException {
             super(plan.getContext(), plan.getTableRef(), plan.getGroupBy(), plan.getOrderBy(),
plan.getStatement().getHint(), plan.getLimit());
             this.plan = plan;
             this.scanGrouper = scanGrouper;
             StatementContext context = plan.getContext();
    +        this.scan = scan == null ? context.getScan() : scan;
    --- End diff --
    
    When is scan null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message