phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Tue, 05 Apr 2016 03:18:14 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58481927
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
    @@ -423,7 +426,14 @@ private RegionScanner scanUnordered(ObserverContext<RegionCoprocessorEnvironment
                             }
                         } while (hasMore && groupByCache.size() < limit);
                     }
    -            } finally {
    +            }  catch(NotServingRegionException e){
    +                if(ScanUtil.isLocalIndex(scan)) {
    +                    Exception cause = new StaleRegionBoundaryCacheException(c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString());
    +                    throw new DoNotRetryIOException(cause.getMessage(), cause);
    +                } else {
    +                    throw e;
    --- End diff --
    
    Is the throw ok because the client scanner knows how to deal with this in cases other
than local indexes? Let's doc that, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message