phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...
Date Tue, 05 Apr 2016 03:16:39 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58481858
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
    @@ -337,6 +384,22 @@ public boolean nextRaw(List<Cell> result) throws IOException
{
                             arrayElementCell = result.get(arrayElementCellPosition);
                         }
                         if (ScanUtil.isLocalIndex(scan) && !ScanUtil.isAnalyzeTable(scan))
{
    --- End diff --
    
    We'll need some code comments here. Are we skipping until we find the actualStartKey row?
Would it be better/possible to do a seek? This seems like it'd be potentially expensive, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message