phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...
Date Tue, 05 Apr 2016 00:09:41 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58469780
  
    --- Diff: phoenix-core/src/test/java/org/apache/phoenix/execute/CorrelatePlanTest.java
---
    @@ -172,17 +172,38 @@ public void testCorrelatePlanWithSingleValueOnly() throws SQLException
{
                     {2, "2", "2", 20},
                     {5, "5", "5", 100},
             };
    -        testCorrelatePlan(LEFT_RELATION, rightRelation, 1, 0, JoinType.Inner, expected);
       
    +        testCorrelatePlan(LEFT_RELATION, rightRelation, 1, 0, JoinType.Inner, expected);
         }
         
    -    private void testCorrelatePlan(Object[][] leftRelation, Object[][] rightRelation,
int leftCorrelColumn, int rightCorrelColumn, JoinType type, Object[][] expectedResult) throws
SQLException {        
    +    @Test
    --- End diff --
    
    Also, test for bind parameter for OFFSET, like this:
    
        SELECT * FROM T OFFSET ?
    
    And check that the ResultSetMetaData and ParameterMetaData are ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message