phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...
Date Tue, 05 Apr 2016 00:07:46 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58469617
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
    @@ -138,6 +138,9 @@
         public final static String SYSTEM_SCHEMA_NAME = "SYSTEM";
         public final static byte[] SYSTEM_SCHEMA_NAME_BYTES = Bytes.toBytes(SYSTEM_SCHEMA_NAME);
         public final static String PHOENIX_METADATA = "table";
    +    public final static String OFFSET = "offset";
    +    public final static byte[] offsetRowKeyBytes = "_OFFSET_".getBytes();
    --- End diff --
    
    Nit: use Bytes.toBytes(OFFSET) instead. Also, did you want it to be "_OFFSET_" for the
OFFSET constant?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message