phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From samarthjain <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...
Date Mon, 04 Apr 2016 23:58:18 GMT
Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r58468877
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
    @@ -1279,4 +1304,129 @@ public static boolean truncateStats(HTableInterface metaTable,
HTableInterface s
             }
             return false;
         }
    +
    +    public static void mapTableToNamespace(HBaseAdmin admin, HTableInterface metatable,
String srcTableName,
    +            String destTableName, ReadOnlyProps props, Long ts, String phoenixTableName,
PTableType pTableType)
    +                    throws SnapshotCreationException, IllegalArgumentException, IOException,
InterruptedException,
    +                    SQLException {
    +        srcTableName = SchemaUtil.normalizeIdentifier(srcTableName);
    +        if (!SchemaUtil.isNamespaceMappingEnabled(
    +                SchemaUtil.isSystemTable(srcTableName.getBytes()) ? PTableType.SYSTEM
: null,
    +                props)) { throw new IllegalArgumentException(SchemaUtil.isSystemTable(srcTableName.getBytes())
    +                        ? "For system table " + QueryServices.IS_SYSTEM_TABLE_MAPPED_TO_NAMESPACE
    +                                + " also needs to be enabled along with " + QueryServices.IS_NAMESPACE_MAPPING_ENABLED
    +                        : QueryServices.IS_NAMESPACE_MAPPING_ENABLED + " is not enabled");
}
    +
    +        if (PTableType.TABLE.equals(pTableType) || PTableType.INDEX.equals(pTableType))
{
    +            admin.snapshot(srcTableName, srcTableName);
    +            admin.cloneSnapshot(srcTableName.getBytes(), destTableName.getBytes());
    +            admin.disableTable(srcTableName);
    +            admin.deleteTable(srcTableName);
    +        }
    +        if (phoenixTableName == null) {
    +            phoenixTableName = srcTableName;
    +        }
    +        Put put = new Put(SchemaUtil.getTableKey(null, SchemaUtil.getSchemaNameFromFullName(phoenixTableName),
    +                SchemaUtil.getTableNameFromFullName(phoenixTableName)), ts);
    +        put.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, PhoenixDatabaseMetaData.IS_NAMESPACE_MAPPED_BYTES,
    +                PBoolean.INSTANCE.toBytes(Boolean.TRUE));
    +        metatable.put(put);
    +    }
    +
    +    public static void mapTableToNamespace(HBaseAdmin admin, HTableInterface metatable,
String tableName,
    +            ReadOnlyProps props, Long ts) throws SnapshotCreationException, IllegalArgumentException,
IOException,
    +                    InterruptedException, SQLException {
    +        String destTablename = SchemaUtil
    +                .normalizeIdentifier(SchemaUtil.getPhysicalTableName(tableName, props).getNameAsString());
    +        mapTableToNamespace(admin, metatable, tableName, destTablename, props, ts, null,
PTableType.TABLE);
    +    }
    +
    +    public static void upgradeTable(PhoenixConnection conn, String srcTable) throws SQLException,
    +            SnapshotCreationException, IllegalArgumentException, IOException, InterruptedException
{
    +        ReadOnlyProps readOnlyProps = conn.getQueryServices().getProps();
    +        if (conn.getClientInfo(PhoenixRuntime.TENANT_ID_ATTRIB) != null) { throw new
SQLException(
    --- End diff --
    
    What if the connection has schema property set? Should we report an error. Looks like
currently we are ignoring it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message