phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...
Date Mon, 04 Apr 2016 23:34:29 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58466849
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
    @@ -168,7 +169,11 @@ public QueryPlan compileUnionAll(SelectStatement select) throws SQLException
{
                 SelectStatement subSelect = unionAllSelects.get(i);
                 // Push down order-by and limit into sub-selects.
                 if (!select.getOrderBy().isEmpty() || select.getLimit() != null) {
    --- End diff --
    
    Does this if statement need to be change to this (and if so, check for other occurrences)?
    
        if (!select.getOrderBy().isEmpty() || select.getLimit() != null || select.getOffset()
!= null)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message