phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2734) Literal expressions for UNSIGNED_DATE/UNSIGNED_TIME/etc
Date Fri, 04 Mar 2016 10:49:40 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179724#comment-15179724
] 

Hadoop QA commented on PHOENIX-2734:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12791432/PHOENIX-2734.patch
  against master branch at commit 57c17ec9299d46c1e3ec44936a73747bbececf9b.
  ATTACHMENT ID: 12791432

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 20 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/267//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/267//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/267//console

This message is automatically generated.

> Literal expressions for UNSIGNED_DATE/UNSIGNED_TIME/etc
> -------------------------------------------------------
>
>                 Key: PHOENIX-2734
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2734
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Sergey Soldatov
>            Assignee: Sergey Soldatov
>         Attachments: PHOENIX-2734.patch
>
>
> At the moment LiteralExpression accepts convertion from varchar to  PDate, PTimestamp
and PTime, but not for the PUnsigned... type. Is there any reason for that or we can just
add an additional check for Unsigned types as well? The problem is that there is no way to
load values to Unsigned date/time types using bulk load ( for regular upsert there is an workaround
to use TO_TIME/etc functions). [~pctony] what do you think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message