phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly
Date Wed, 30 Mar 2016 01:18:25 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217188#comment-15217188
] 

Andrew Purtell commented on PHOENIX-2628:
-----------------------------------------

bq. - We'll need someone like [~apurtell] to review and bless IndexHalfStoreFileReader and
IndexHalfStoreFileReaderGenerator. For example, is it copacetic to derive from {{StoreFile.Reader}}?

IndexHalfStoreFileReader - looks ok, but extending StoreFile.Reader is a bit iffy. StoreFile
is LP(coproc) but Reader is not tagged. You should submit a patch that tags Reader as also
LP(coproc). 

IndexHalfStoreFileReaderGenerator - looks ok

LocalIndexStoreFileScanner - looks ok


> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
>                 Key: PHOENIX-2628
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2628
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Rajeshbabu Chintaguntla
>         Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch, PHOENIX-2628_v7.patch,
PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for scans and aggregates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message