phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maryannxue <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2722 support mysql limit,offset clau...
Date Tue, 29 Mar 2016 02:16:51 GMT
Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r57664171
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java ---
    @@ -193,21 +194,32 @@ protected ResultIterator newIterator(ParallelScanGrouper scanGrouper)
throws SQL
              * limit is provided, run query serially.
              */
             boolean isOrdered = !orderBy.getOrderByExpressions().isEmpty();
    -        boolean isSerial = isSerial(context, statement, tableRef, orderBy, limit, allowPageFilter);
    +        boolean isSerial = isSerial(context, statement, tableRef, orderBy, limit, offset,
allowPageFilter);
             Integer perScanLimit = !allowPageFilter || isOrdered ? null : limit;
    +        if (perScanLimit != null) {
    +            perScanLimit += (offset == null ? 0 : offset);
    +        }
    +		boolean hasOffset = offset != null;
    --- End diff --
    
    Looks like there's <tab> here and a few lines below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message