Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72F9F18BBF for ; Fri, 12 Feb 2016 01:57:21 +0000 (UTC) Received: (qmail 84582 invoked by uid 500); 12 Feb 2016 01:57:21 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 84525 invoked by uid 500); 12 Feb 2016 01:57:21 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 84514 invoked by uid 99); 12 Feb 2016 01:57:21 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2016 01:57:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E3A181A032F for ; Fri, 12 Feb 2016 01:57:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.549 X-Spam-Level: X-Spam-Status: No, score=-3.549 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KzGVIA8K6zRe for ; Fri, 12 Feb 2016 01:57:20 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 1602E31AE4 for ; Fri, 12 Feb 2016 01:57:18 +0000 (UTC) Received: (qmail 83870 invoked by uid 99); 12 Feb 2016 01:57:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2016 01:57:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 28ECF2C14F6 for ; Fri, 12 Feb 2016 01:57:18 +0000 (UTC) Date: Fri, 12 Feb 2016 01:57:18 +0000 (UTC) From: "Jesse Yates (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-2674) PhoenixMapReduceUtil#setInput doesn't honor condition clause MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse Yates updated PHOENIX-2674: --------------------------------- Attachment: PHOENIX-2674.patch Attaching formal patch that includes m/r test for with and without columns specification. Followed the example from the website so maybe we can link this later. [~giacomotaylor] what do you think? > PhoenixMapReduceUtil#setInput doesn't honor condition clause > ------------------------------------------------------------ > > Key: PHOENIX-2674 > URL: https://issues.apache.org/jira/browse/PHOENIX-2674 > Project: Phoenix > Issue Type: Bug > Reporter: Jesse Yates > Assignee: Jesse Yates > Attachments: PHOENIX-2674.patch, phoenix-2674-v0-without-test.patch > > > The parameter is completely unused in the method. Further, it looks like we don't actually test this method or any m/r tools directly. > It would be good to (a) have explicit tests for the MapReduce code - rather than relying on indirect tests like the index util - and, (b) have an example in code for using the mapreduce tools, rather than just the web docs (which can become out of date). -- This message was sent by Atlassian JIRA (v6.3.4#6332)