phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2681) Avoid usage of HashSet<byte[]> in guideposts selection
Date Fri, 12 Feb 2016 05:46:18 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144091#comment-15144091
] 

Hudson commented on PHOENIX-2681:
---------------------------------

SUCCESS: Integrated in Phoenix-master #1130 (See [https://builds.apache.org/job/Phoenix-master/1130/])
PHOENIX-2681 Avoid usage of HashSet<byte[]> in guideposts selection (jtaylor: rev 18f7a69452eec7fd5fde38953510600c4a060151)
* phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/MultiCfQueryExecIT.java


> Avoid usage of HashSet<byte[]> in guideposts selection
> ------------------------------------------------------
>
>                 Key: PHOENIX-2681
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2681
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2681.patch
>
>
> We use HashSet<byte[]> in our code to select which guideposts to use. It works
because we luckily use the byte[] stored on the PTable consistently. It's possible that the
array would be a different instance if the PTable was updated. In general, it's bad practice
to use a HashSet with an array, so this updates that along with some other minor cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message