phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2674) PhoenixMapReduceUtil#setInput doesn't honor condition clause
Date Sat, 13 Feb 2016 00:16:18 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145603#comment-15145603
] 

Jesse Yates commented on PHOENIX-2674:
--------------------------------------

Test suite passed locally. Pretty sure about this one. Committed to appropriate branches.

> PhoenixMapReduceUtil#setInput doesn't honor condition clause
> ------------------------------------------------------------
>
>                 Key: PHOENIX-2674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2674
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2674.patch, phoenix-2674-v0-without-test.patch
>
>
> The parameter is completely unused in the method. Further, it looks like we don't actually
test this method or any m/r tools directly.
> It would be good to (a) have explicit tests for the MapReduce code - rather than relying
on indirect tests like the index util - and, (b) have an example in code for using the mapreduce
tools, rather than just the web docs (which can become out of date).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message