Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Wed, 20 Jan 2016 05:20:39 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12932274.1453166526000.154878.1453267239799@Atlassian.JIRA>
In-Reply-To: <JIRA.12932274.1453166526000@Atlassian.JIRA>
References: <JIRA.12932274.1453166526000@Atlassian.JIRA>
 <JIRA.12932274.1453166526416@arcas>
Subject: [jira] [Commented] (PHOENIX-2610) Allow passing PHOENIX_OPTS to
 command line utils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PHOENIX-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108031#comment-15108031 ] 

Hadoop QA commented on PHOENIX-2610:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12783276/2610.01.patch
  against master branch at commit 1717f12d7c6e9b1ee8ddffb55cea929d6d8543f1.
  ATTACHMENT ID: 12783276

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 33 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +java_cmd = '%(java)s $PHOENIX_OPTS -cp ' + hbase_config_path + os.pathsep + hadoop_config_path + os.pathsep + \
+    ' -cp "' + phoenix_utils.hbase_conf_dir + os.pathsep + phoenix_utils.phoenix_client_jar + os.pathsep + phoenix_utils.hadoop_common_jar + os.pathsep + phoenix_utils.hadoop_hdfs_jar + \
+    '-cp ' + hbase_config_path + os.pathsep + phoenix_utils.phoenix_traceserver_jar + os.pathsep + phoenix_utils.phoenix_client_jar + \

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexExpressionIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/229//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/229//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/229//console

This message is automatically generated.

> Allow passing PHOENIX_OPTS to command line utils
> ------------------------------------------------
>
>                 Key: PHOENIX-2610
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2610
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Trivial
>             Fix For: 4.7.0
>
>         Attachments: 2610.00.patch, 2610.01.patch
>
>
> Much of Phoenix exists on the client-side. Allow users to override client-side JVM properties via an environment variable, following Hadoop and HBase conventions, {{PHOENIX_OPTS}}.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)