Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A736918CAF for ; Tue, 19 Jan 2016 05:09:41 +0000 (UTC) Received: (qmail 76451 invoked by uid 500); 19 Jan 2016 05:09:41 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 76391 invoked by uid 500); 19 Jan 2016 05:09:41 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 76380 invoked by uid 99); 19 Jan 2016 05:09:41 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 05:09:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 13FD4C2E6D for ; Tue, 19 Jan 2016 05:09:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.979 X-Spam-Level: X-Spam-Status: No, score=0.979 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EzJ3EiyKwGsq for ; Tue, 19 Jan 2016 05:09:40 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 8318B21265 for ; Tue, 19 Jan 2016 05:09:40 +0000 (UTC) Received: (qmail 76374 invoked by uid 99); 19 Jan 2016 05:09:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 05:09:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C7E092C14F2 for ; Tue, 19 Jan 2016 05:09:39 +0000 (UTC) Date: Tue, 19 Jan 2016 05:09:39 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-2591) Minimize transaction commit/rollback for DDL MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-2591: ---------------------------------- Attachment: PHOENIX-2591.patch Please review, [~tdsilva]. We can use the write pointer and not have to do the funky commit stuff as long as we use tx.getTransactionId() which doesn't change (it's the initial write pointer). > Minimize transaction commit/rollback for DDL > -------------------------------------------- > > Key: PHOENIX-2591 > URL: https://issues.apache.org/jira/browse/PHOENIX-2591 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: Thomas D'Silva > Fix For: 4.7.0 > > Attachments: PHOENIX-2591.patch > > > Seems that the number of times we commit/rollback transactions during DDL operations could be improved. See TransactionUtil.getTableTimestamp() for example. There'd also be another couple when MutationState.commitWriteFence() is called when a CREATE INDEX is performed too. > I realize we're doing this to get the transaction read pointer to "catch up" to the current time, as we use the read pointer as our "current time" for transactional tables. However, what would the impact be if we used the transaction write pointer instead? > At a minimum, we need to document what we're doing before we forget. -- This message was sent by Atlassian JIRA (v6.3.4#6332)