phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-1874) Add tests for both JONI and Java regex usage
Date Sun, 24 Jan 2016 01:24:39 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Taylor updated PHOENIX-1874:
----------------------------------
    Fix Version/s:     (was: 4.4.1)
                   4.8.0

> Add tests for both JONI and Java regex usage
> --------------------------------------------
>
>                 Key: PHOENIX-1874
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1874
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>             Fix For: 4.8.0
>
>
> We should have tests that use both the JONI regex library and the Java regex library.
One easy way would be to do the following:
> - Pull out the regex related tests from VariableLengthPKIT into a new abstract RegExIT
test class
> - Derive two concrete class from RegExIT: JoniRegExIT and JavaRegExIT
> - Set QueryServices.USE_BYTE_BASED_REGEX_ATTRIB to true in one and false in the other.
You'd do this by each having a static doSetup() method like this:
> {code}
>     @BeforeClass
>     @Shadower(classBeingShadowed = BaseHBaseManagedTimeIT.class)
>     public static void doSetup() throws Exception {
>         Map<String,String> props = Maps.newHashMapWithExpectedSize(3);        
   
>         props.put(QueryServices.USE_BYTE_BASED_REGEX_ATTRIB,
>             Boolean.toString(true));
>         setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator()));
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message