phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2417 Compress memory used by row key...
Date Sat, 16 Jan 2016 02:30:50 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/147#discussion_r49925674
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
    @@ -490,15 +492,35 @@ private static String toString(List<byte[]> gps) {
             }
             List<List<Scan>> parallelScans = Lists.newArrayListWithExpectedSize(stopIndex
- regionIndex + 1);
             
    -        byte[] currentKey = startKey;
    -        int guideIndex = currentKey.length == 0 ? 0 : getIndexContainingInclusive(gps,
currentKey);
    -        int gpsSize = gps.size();
    +        ImmutableBytesWritable currentKey = new ImmutableBytesWritable(startKey, 0, startKey.length);
    +        
    +        int gpsSize = gps.getGuidePostsCount();
             int estGuidepostsPerRegion = gpsSize == 0 ? 1 : gpsSize / regionLocations.size()
+ 1;
             int keyOffset = 0;
    +        ImmutableBytesWritable currentGuidePost = ByteUtil.EMPTY_IMMUTABLE_BYTE_ARRAY;
             List<Scan> scans = Lists.newArrayListWithExpectedSize(estGuidepostsPerRegion);
    +        ImmutableBytesWritable guidePosts = gps.getGuidePosts();
    +        ByteArrayInputStream stream = null;
    +        DataInput input = null;
    +        PrefixByteDecoder decoder = null;
    +        int guideIndex = 0;
    +        if (gpsSize > 0) {
    +            stream = new ByteArrayInputStream(guidePosts.get(), guidePosts.getOffset(),
guidePosts.getLength());
    +            input = new DataInputStream(stream);
    +            decoder = new PrefixByteDecoder(gps.getMaxLength());
    +            try {
    +                while (currentKey.compareTo(currentGuidePost = CodecUtils.decode(decoder,
input)) >= 0
    +                        && currentKey.getLength() != 0) {
    +                    guideIndex++;
    +                }
    +            } catch (EOFException e) {}
    +        }
    +        byte[] currentKeyBytes = currentKey.copyBytes();
    +
             // Merge bisect with guideposts for all but the last region
             while (regionIndex <= stopIndex) {
    -            byte[] currentGuidePost, endKey, endRegionKey = EMPTY_BYTE_ARRAY;
    +            byte[] currentGuidePostBytes = currentGuidePost.copyBytes();
    --- End diff --
    
    And here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message