Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 15 Dec 2015 22:08:46 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12922154.1450216766000.31824.1450217326659@Atlassian.JIRA>
In-Reply-To: <JIRA.12922154.1450216766000@Atlassian.JIRA>
References: <JIRA.12922154.1450216766000@Atlassian.JIRA>
 <JIRA.12922154.1450216766260@arcas>
Subject: [jira] [Commented] (PHOENIX-2531) Phoenix thin-client jar has
 incorrect META-INF/services/java.sql.Driver file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PHOENIX-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058932#comment-15058932 ] 

Josh Elser commented on PHOENIX-2531:
-------------------------------------

[~ndimiduk], this is the issue I had mentioned to you earlier.

> Phoenix thin-client jar has incorrect META-INF/services/java.sql.Driver file
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-2531
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2531
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2531.patch
>
>
> Trying to hook up the thin-client to pherf, I was having some troubles with being unable to find the thin-client Driver. I knew that we should be getting it loaded by the service definition contained in the jar {{META-INF/services/java.sql.Driver}}.
> Upon inspection of the "normal" jar produced by {{phoenix-server-client}}, the contents of the file were as we expect {{org.apache.phoenix.queryserver.client.Driver}}. However, the top-level "thin-client" jar we bundle in the tarball had a value of {{org.apache.calcite.avatica.remote.Driver}} instead.
> It seems like when we built {{phoenix-$VERSION-thin-client.jar}} (jar-with-dependencies is all it is, really), Avatica's {{META-INF/services/java.sql.Driver}} was overwriting the copy we had in {{phoenix-server-client/src/main/resources}}. I'm not sure how/why we didn't notice this yet (for example, why did sqlline-thin.py work?), but it's definitely busted for how it _should_ work.
> It's a simple enough fix to explicitly set the file in the assembly descriptor.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)