Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95F9618B63 for ; Thu, 19 Nov 2015 07:04:29 +0000 (UTC) Received: (qmail 48890 invoked by uid 500); 19 Nov 2015 07:04:29 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 48826 invoked by uid 500); 19 Nov 2015 07:04:29 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 48815 invoked by uid 99); 19 Nov 2015 07:04:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2015 07:04:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CB115E027F; Thu, 19 Nov 2015 07:04:28 +0000 (UTC) From: JamesRTaylor To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request: PHOENIX-1674 Snapshot isolation transaction ... Content-Type: text/plain Message-Id: <20151119070428.CB115E027F@git1-us-west.apache.org> Date: Thu, 19 Nov 2015 07:04:28 +0000 (UTC) Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/129#issuecomment-157971369 I can't find PhoenixTransactionalIndexer. Did your latest pull forget to add new files? Or maybe I'm just missing it? FYI, I remember there are a few bits of commented out code that should be removed from that file. Everything else looks good to me - except for a few minor comments above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---