phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-2421) Disable checkstyle plugin by default
Date Mon, 16 Nov 2015 18:08:11 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nick Dimiduk updated PHOENIX-2421:
----------------------------------
    Attachment: 2421.00.patch

Without patch:
{noformat}
$ time mvn clean package -DskipTests
...
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:31 min
[INFO] Finished at: 2015-11-16T09:51:45-08:00
[INFO] Final Memory: 108M/1403M
[INFO] ------------------------------------------------------------------------

real    2m33.460s
user    4m46.007s
sys     0m12.124s
{noformat}

With patch:
{noformat}
$ time mvn clean package -DskipTests
...
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:49 min
[INFO] Finished at: 2015-11-16T09:47:41-08:00
[INFO] Final Memory: 202M/1624M
[INFO] ------------------------------------------------------------------------

real    1m50.937s
user    3m40.331s
sys     0m10.082s
{noformat}

Checkstyle can still be run manually, using all existing configuration, with {{mvn checkstyle:check}}.

> Disable checkstyle plugin by default
> ------------------------------------
>
>                 Key: PHOENIX-2421
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2421
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Nick Dimiduk
>            Priority: Minor
>         Attachments: 2421.00.patch
>
>
> We haven't invested much time into improving the codebase re: checkstyle warnings. From
what I can tell, the only thing gained from invoking the {{check}} goal automatically is longer
build times.
> Let's disable it by default until such time as we have some reporting on checkstyle warnings
in our precommit reports (similar to HBase).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message