phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1674) Snapshot isolation transaction support through Tephra
Date Tue, 24 Nov 2015 00:28:11 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023467#comment-15023467
] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/133#discussion_r45682394
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
    @@ -111,8 +115,10 @@ public boolean equals(Object obj) {
             if (obj == null) return false;
             if (getClass() != obj.getClass()) return false;
             TableRef other = (TableRef)obj;
    +        // a null alias on either side should mean a wildcard and should not fail the
equals check
             if ((alias == null && other.alias != null) || (alias != null &&
!alias.equals(other.alias))) return false;
    -        if (!table.getName().getString().equals(other.table.getName().getString())) return
false;
    +        if ((table.getName() == null && other.table.getName() != null) 
    --- End diff --
    
    The code I posted will work fine if table.getName() is null, no?


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one option for getting
transaction support in Phoenix. Let's use this JIRA to discuss the way in which this could
be integrated along with the pros and cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message