phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1674) Snapshot isolation transaction support through Tephra
Date Mon, 23 Nov 2015 23:35:11 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023343#comment-15023343
] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/133#discussion_r45677707
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java ---
    @@ -209,13 +212,34 @@ private static boolean isEmptyKeyValue(PTable table, ColumnReference
ref) {
                                 .getLength()) == 0);
         }
     
    +    public static List<Delete> generateDeleteIndexData(final PTable table, PTable
index,
    +            List<Delete> dataMutations, ImmutableBytesWritable ptr, final KeyValueBuilder
kvBuilder, PhoenixConnection connection)
    +            throws SQLException {
    +        try {
    +            IndexMaintainer maintainer = index.getIndexMaintainer(table, connection);
    +            List<Delete> indexMutations = Lists.newArrayListWithExpectedSize(dataMutations.size());
    +            for (final Mutation dataMutation : dataMutations) {
    +                long ts = MetaDataUtil.getClientTimeStamp(dataMutation);
    +                ptr.set(dataMutation.getRow());
    +                Delete delete = maintainer.buildDeleteMutation(kvBuilder, ptr, ts);
    +                // TODO: move to TransactionUtil
    --- End diff --
    
    Not sure if the TODO is needed here. Remove on commit.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one option for getting
transaction support in Phoenix. Let's use this JIRA to discuss the way in which this could
be integrated along with the pros and cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message