phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1674) Snapshot isolation transaction support through Tephra
Date Thu, 19 Nov 2015 17:14:10 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013934#comment-15013934
] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/129#discussion_r45370189
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
    @@ -135,230 +154,282 @@ public void tearDown() throws Exception {
         @Ignore("See PHOENIX-2331")
         @Test(timeout=300000)
         public void testWriteFailureDisablesLocalIndex() throws Exception {
    -        testWriteFailureDisablesIndex(true);
    +        helpTestWriteFailureDisablesIndex(true);
         }
      
         @Ignore("See PHOENIX-2332")
         @Test(timeout=300000)
         public void testWriteFailureDisablesIndex() throws Exception {
    -        testWriteFailureDisablesIndex(false);
    +        helpTestWriteFailureDisablesIndex(false);
         }
         
    -    public void testWriteFailureDisablesIndex(boolean localIndex) throws Exception {
    -        String query;
    -        ResultSet rs;
    -
    +    public void helpTestWriteFailureDisablesIndex(boolean localIndex) throws Exception
{
             Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
    -        Connection conn = driver.connect(url, props);
    -        conn.setAutoCommit(false);
    -        conn.createStatement().execute(
    -                "CREATE TABLE " + DATA_TABLE_FULL_NAME + " (k VARCHAR NOT NULL PRIMARY
KEY, v1 VARCHAR, v2 VARCHAR)");
    -        query = "SELECT * FROM " + DATA_TABLE_FULL_NAME;
    -        rs = conn.createStatement().executeQuery(query);
    -        assertFalse(rs.next());
    -
    -        if(localIndex) {
    -            conn.createStatement().execute(
    -                "CREATE LOCAL INDEX " + INDEX_TABLE_NAME + " ON " + DATA_TABLE_FULL_NAME
+ " (v1) INCLUDE (v2)");
    -            conn.createStatement().execute(
    -                "CREATE LOCAL INDEX " + INDEX_TABLE_NAME+ "_2" + " ON " + DATA_TABLE_FULL_NAME
+ " (v2) INCLUDE (v1)");
    -        } else {
    +        try (Connection conn = driver.connect(url, props)) {
    +            String query;
    +            ResultSet rs;
    +            conn.setAutoCommit(false);
                 conn.createStatement().execute(
    -                "CREATE INDEX " + INDEX_TABLE_NAME + " ON " + DATA_TABLE_FULL_NAME +
" (v1) INCLUDE (v2)");
    -        }
    +                    "CREATE TABLE " + DATA_TABLE_FULL_NAME + " (k VARCHAR NOT NULL PRIMARY
KEY, v1 VARCHAR, v2 VARCHAR)");
    --- End diff --
    
    I messed up the merge on this file, its not creating a transactional table, I will fix
this.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one option for getting
transaction support in Phoenix. Let's use this JIRA to discuss the way in which this could
be integrated along with the pros and cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message