phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1674 Snapshot isolation transaction ...
Date Thu, 19 Nov 2015 06:48:19 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/129#discussion_r45307287
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java ---
    @@ -223,23 +223,25 @@ public final ResultIterator iterator(final List<? extends SQLCloseable>
dependen
             if (table.getType() != PTableType.SYSTEM) {
                 scan.setConsistency(connection.getConsistency());
             }
    -        // Get the time range of row_timestamp column
    -        TimeRange rowTimestampRange = context.getScanRanges().getRowTimestampRange();
    -        // Get the already existing time range on the scan.
    -        TimeRange scanTimeRange = scan.getTimeRange();
    -        Long scn = connection.getSCN();
    -        if (scn == null) {
    -            scn = context.getCurrentTime();
    -        }
    -        try {
    -            TimeRange timeRangeToUse = ScanUtil.intersectTimeRange(rowTimestampRange,
scanTimeRange, scn);
    -            if (timeRangeToUse == null) {
    -                return ResultIterator.EMPTY_ITERATOR;
    -            }
    -            scan.setTimeRange(timeRangeToUse.getMin(), timeRangeToUse.getMax());
    -        } catch (IOException e) {
    -            throw new RuntimeException(e);
    -        }
    +        if (!table.isTransactional()) {
    --- End diff --
    
    Add TODO here referencing our JIRA to fix this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message