phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-1372) Fix resource leaks in various classes
Date Wed, 07 Oct 2015 14:45:26 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated PHOENIX-1372:
----------------------------
    Description: 
Statement / PreparedStatement should be closed after query completes.
Below is an example of resource leak from MetaDataUtil#deleteViewIndexSequences():
{code}
     public static void deleteViewIndexSequences(PhoenixConnection connection, PName name)
throws SQLException {
         SequenceKey key = getViewIndexSequenceKey(null, name);
        connection.createStatement().executeUpdate("DELETE FROM " + PhoenixDatabaseMetaData.SEQUENCE_TABLE_NAME
+
{code}

The Statement created by connection.createStatement() should be closed upon return.

  was:
Statement / PreparedStatement should be closed after query completes.
Below is an example of resource leak from MetaDataUtil#deleteViewIndexSequences():
{code}
     public static void deleteViewIndexSequences(PhoenixConnection connection, PName name)
throws SQLException {
         SequenceKey key = getViewIndexSequenceKey(null, name);
        connection.createStatement().executeUpdate("DELETE FROM " + PhoenixDatabaseMetaData.SEQUENCE_TABLE_NAME
+
{code}
The Statement created by connection.createStatement() should be closed upon return.


> Fix resource leaks in various classes
> -------------------------------------
>
>                 Key: PHOENIX-1372
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1372
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>              Labels: resources
>         Attachments: 1372-v1.txt
>
>
> Statement / PreparedStatement should be closed after query completes.
> Below is an example of resource leak from MetaDataUtil#deleteViewIndexSequences():
> {code}
>      public static void deleteViewIndexSequences(PhoenixConnection connection, PName
name) throws SQLException {
>          SequenceKey key = getViewIndexSequenceKey(null, name);
>         connection.createStatement().executeUpdate("DELETE FROM " + PhoenixDatabaseMetaData.SEQUENCE_TABLE_NAME
+
> {code}
> The Statement created by connection.createStatement() should be closed upon return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message