phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2183) Write to log when actually doing WAL replay
Date Tue, 18 Aug 2015 00:41:45 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700528#comment-14700528
] 

James Taylor commented on PHOENIX-2183:
---------------------------------------

bq. Only concern would be renaming the JIRA - at first glance this implies writing the WAL
when doing WAL replay, not just doing the debug/progress logging.
Do'h. That's what I assumed it was about (sorry to bug you about it) - I'll rename the JIRA.

> Write to log when actually doing WAL replay
> -------------------------------------------
>
>                 Key: PHOENIX-2183
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2183
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Yuhao Bi
>         Attachments: PHOENIX-2183.patch
>
>
> In Indexer#postOpen(...) we write the log in any condition.
> {code}
>     LOG.info("Found some outstanding index updates that didn't succeed during"
>         + " WAL replay - attempting to replay now.");
>     //if we have no pending edits to complete, then we are done
>     if (updates == null || updates.size() == 0) {
>       return;
>     }
> {code}
> We should only write the log when we actually doing a replay.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message