phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1661) Implement built-in functions for JSON
Date Tue, 25 Aug 2015 00:37:45 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710341#comment-14710341
] 

ASF GitHub Bot commented on PHOENIX-1661:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/102#discussion_r37821754
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JsonEachFunctionIT.java
---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end;
    +
    +import org.apache.phoenix.schema.types.PhoenixArray;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.junit.Test;
    +
    +import java.sql.*;
    +import java.util.Properties;
    +
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.*;
    +
    +/**
    + * End to end test for {@link org.apache.phoenix.expression.function.JsonEachFunction}.
    + *
    + */
    +public class JsonEachFunctionIT extends BaseHBaseManagedTimeIT {
    +
    +    @Test
    +      public void testJsonEach() throws Exception {
    +        Connection conn = getConnection();
    +
    +        try{
    +            String json =
    +                    "{\"f2\":{\"f3\":\"value\"},\"f4\":{\"f5\":99,\"f6\":[1,true,\"foo\"]},\"f7\":true}";
    +            populateJsonTable(conn, json, "valueOne");
    +
    +            String selectQuery = "SELECT json_each(col1) FROM testJson WHERE pk = 'valueOne'";
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            String[] strArr = new String[]{
    +                    "f2,{\"f3\":\"value\"}",
    +                    "f4,{\"f5\":99,\"f6\":[1,true,\"foo\"]}",
    +                    "f7,true"};
    +            Array array = conn.createArrayOf("VARCHAR", strArr);
    +            PhoenixArray resultArray = (PhoenixArray) rs.getArray(1);
    +            assertEquals("JsonEach return data is not as expected.", resultArray,
    +                    array);
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +
    +    @Test
    +    public void testJsonEachWithNullKey() throws Exception {
    +        Connection conn = getConnection();
    +
    +        try{
    +            String json =
    +                    "100";
    --- End diff --
    
    This should throw an exception because 100 is not valid json.


> Implement built-in functions for JSON
> -------------------------------------
>
>                 Key: PHOENIX-1661
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1661
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: LeiWang
>              Labels: JSON, Java, SQL, gsoc2015, mentor
>         Attachments: PHOENIX-1661.patch, PhoenixJSONSpecification-First-Draft.pdf
>
>
> Take a look at the JSON built-in functions that are implemented in Postgres (http://www.postgresql.org/docs/9.3/static/functions-json.html)
and implement the same for Phoenix in Java following this guide: http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
> Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The implementation
of these built-in functions will be impacted by how JSON is stored in Phoenix. See PHOENIX-628.
An initial implementation could work off of a simple text-based JSON representation and then
when a native JSON type is implemented, they could be reworked to be more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message