phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2196 - auto capitalize field names i...
Date Sun, 23 Aug 2015 19:55:01 GMT
Github user JamesRTaylor commented on the pull request:

    https://github.com/apache/phoenix/pull/114#issuecomment-133910608
  
    Yes, I think that would work. We'd need unit tests around this too, please. The function
we go through to normalize identifier/column references is SchemaUtil.normalizeIdentifier(String
identifier). Here's a SQL example (which would work fine):
    {code}
    CREATE TABLE "t" (id VARCHAR PRIMARY KEY, "v" VARCHAR);
    UPSERT INTO "t" (ID, "v") VALUES ('a','b');
    SELECT ID, "v" FROM "t";
    SELECT id, "v" FROM "t";
    {code}
    
    Would you have some cycles to review this pull, @jmahonin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message