phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Mahonin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2088) Prevent splitting and recombining select expressions for MR integration
Date Tue, 21 Jul 2015 01:38:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634392#comment-14634392
] 

Josh Mahonin commented on PHOENIX-2088:
---------------------------------------

Totally agree on standardizing on a common interface.

The spark integration tests fail with this patch, although on line 32 on ConfigurationUtil.scala
if I replace 'setOutputTableName' with 'setColInfoTableName', that seems to get things going
again. It's not clear to me if this supercedes the setOutputTableName, or if they're both
necessary now?

> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-2088
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2088
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-2088-4.4-HBase-0.98.patch, PHOENIX-2088-pig.patch, PHOENIX-2088-wip-v2.patch,
PHOENIX-2088-wip-v3.patch, PHOENIX-2088-wip.patch
>
>
> We currently send in the select expressions for the MR integration with a delimiter separated
string, split based on the delimiter, and then recombine again using a comma separator. This
is problematic because the delimiter character may appear in a select expression, thus breaking
this logic. Instead, we should use a comma as the delimiter and avoid splitting and recombining
as it's not necessary in that case. Instead, the entire string can be used as-is in that case
to form the select expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message