phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2064) ARRAY constructor doesn't work when used in COUNT DISTINCT
Date Fri, 03 Jul 2015 15:44:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613252#comment-14613252
] 

James Taylor commented on PHOENIX-2064:
---------------------------------------

Looks good. Do the tests all pass now? One minor nit, make valuePtr final and make it an ImmutableBytesWritable
instead of an ImmutableBytesPtr. The difference is that ImmutableBytesPtr caches the hashCode
for better performance if it's used in a hash map (which it won't be):
{code}
+    private final ImmutableBytesWritable valuePtr = new ImmutableBytesWritable();
{code}



> ARRAY constructor doesn't work when used in COUNT DISTINCT
> ----------------------------------------------------------
>
>                 Key: PHOENIX-2064
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2064
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Dumindu Buddhika
>         Attachments: PHOENIX-2064-v2.patch, PHOENIX-2064-v3.patch, PHOENIX-2064.patch
>
>
> As a workaround for PHOENIX-2062, I tried the following query:
> {code}
> SELECT COUNT(DISTINCT ARRAY[a.col1, b.col2]) ...
> {code}
> However, this always returns the full number of rows which is wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message