phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1661) Implement built-in functions for JSON
Date Fri, 31 Jul 2015 20:47:05 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649817#comment-14649817
] 

ASF GitHub Bot commented on PHOENIX-1661:
-----------------------------------------

Github user AakashPradeep commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/102#discussion_r36014695
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/JsonArrayLengthFunctionIT.java
---
    @@ -0,0 +1,177 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end;
    +
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.*;
    +
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Properties;
    +
    +import org.apache.phoenix.exception.SQLExceptionCode;
    +import org.apache.phoenix.expression.function.JsonArrayLengthFunction;
    +import org.apache.phoenix.schema.IllegalDataException;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.junit.Test;
    +
    +/**
    + * End to end test for {@link JsonArrayLengthFunction}.
    + *
    + */
    +public class JsonArrayLengthFunctionIT extends BaseHBaseManagedTimeIT {
    +
    +	@Test
    +	public void testJsonArrayLengthWithIntTypeInWhereClause() throws Exception {
    +		Connection conn = getConnection();
    +		String json = "[1,2,3]";
    +		String pk = "valueOne";
    +		try {
    +			populateJsonTable(conn, json, pk);
    +
    +			String selectQuery = "SELECT col1 FROM testJson WHERE json_array_length(col1) = 3";
    +			PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +			ResultSet rs = stmt.executeQuery();
    +			assertTrue(rs.next());
    +			assertEquals("Json data is not as expected.", json,
    +					rs.getString(1));
    +			assertFalse(rs.next());
    +
    +		} finally {
    +			conn.close();
    +		}
    +	}
    +
    +    @Test
    +    public void testJsonArrayLengthWithDoubleType() throws Exception {
    +        Connection conn = getConnection();
    +        String json = "[1.23,2.34,3.56,54.3]";
    +        String pk = "valueOne";
    +        try {
    +            populateJsonTable(conn, json, pk);
    +
    +            String selectQuery = "SELECT json_array_length(col1) FROM testJson WHERE
pk = 'valueOne'";
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            assertEquals("Json array length is not as expected.", 4,
    +                    rs.getInt(1));
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +
    +    @Test
    +    public void testJsonArrayLengthWithDifferentDataTypes()
    +            throws Exception {
    +        Connection conn = getConnection();
    +        String json = "[1,2.3,true,\"f1\",[\"string\",3]]";
    +        String pk = "valueOne";
    +        try {
    +            populateJsonTable(conn, json, pk);
    +
    +            String selectQuery = "SELECT json_array_length(col1) FROM testJson WHERE
pk = 'valueOne'";
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            assertEquals("Json array length is not as expected.",
    +                    5, rs.getInt(1));
    +
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +    @Test
    +    public void testJsonArrayLengthWithNestedJson() throws Exception {
    +        Connection conn = getConnection();
    +        String json = "[1,\"string\",false,[1.23,[true,\"ok\"]]]";
    +        String pk = "valueOne";
    +        try {
    +            populateJsonTable(conn, json, pk);
    +
    +            String selectQuery = "SELECT col1 FROM testJson WHERE json_array_length(col1)
= 4";
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            assertEquals("Json data read from DB is not as expected.", json,
    +                    rs.getString(1));
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +    @Test
    +    public void testJsonArrayLengthWithInvalidJson() throws Exception {
    --- End diff --
    
    rename test as suggested above


> Implement built-in functions for JSON
> -------------------------------------
>
>                 Key: PHOENIX-1661
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1661
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: LeiWang
>              Labels: JSON, Java, SQL, gsoc2015, mentor
>         Attachments: PhoenixJSONSpecification-First-Draft.pdf
>
>
> Take a look at the JSON built-in functions that are implemented in Postgres (http://www.postgresql.org/docs/9.3/static/functions-json.html)
and implement the same for Phoenix in Java following this guide: http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
> Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The implementation
of these built-in functions will be impacted by how JSON is stored in Phoenix. See PHOENIX-628.
An initial implementation could work off of a simple text-based JSON representation and then
when a native JSON type is implemented, they could be reworked to be more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message