phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elilevine <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-978: Allow views to extend parent's ...
Date Thu, 09 Jul 2015 02:25:01 GMT
Github user elilevine commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/97#discussion_r34219051
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
    @@ -2132,15 +2131,13 @@ public void testAddExistingViewColumnToBaseTableWithViews() throws
Exception {
         }
         
         @Test
    -    @Ignore
    -    // enable this test after https://issues.apache.org/jira/browse/PHOENIX-978 is fixed

         public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception {
             Connection conn = DriverManager.getConnection(getUrl());
             try {       
                 conn.createStatement().execute("CREATE TABLE IF NOT EXISTS TABLEWITHVIEW
("
                         + " ID char(10) NOT NULL,"
                         + " COL1 integer NOT NULL,"
    -                    + " COL2 bigint NOT NULL,"
    +                    + " COL2 integer NOT NULL,"
    --- End diff --
    
    Parent's last PK column must be fixed-length now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message