Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69FE51825C for ; Tue, 9 Jun 2015 00:38:03 +0000 (UTC) Received: (qmail 96194 invoked by uid 500); 9 Jun 2015 00:38:03 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 96135 invoked by uid 500); 9 Jun 2015 00:38:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 96124 invoked by uid 99); 9 Jun 2015 00:38:03 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 00:38:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9BD3B183996 for ; Tue, 9 Jun 2015 00:38:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.97 X-Spam-Level: X-Spam-Status: No, score=0.97 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gsZlfAItAnsc for ; Tue, 9 Jun 2015 00:38:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 8244C42AD6 for ; Tue, 9 Jun 2015 00:38:01 +0000 (UTC) Received: (qmail 96101 invoked by uid 99); 9 Jun 2015 00:38:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jun 2015 00:38:00 +0000 Date: Tue, 9 Jun 2015 00:38:00 +0000 (UTC) From: "Shuxiong Ye (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-1987) SIGN built-in function should be order preserving MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578129#comment-14578129 ] Shuxiong Ye commented on PHOENIX-1987: -------------------------------------- Hi [~jamestaylor], Patch [1] adds tests in QueryCompilerTest to check optimization about ORDER BY. Please help me to review it. I have a question in my previous comment. Please give me some hints about it. : ) [1] 0001-PHOENIX-1987-fixing-getKeyFormationTraversalIndex-in-SIGN-function.patch > SIGN built-in function should be order preserving > ------------------------------------------------- > > Key: PHOENIX-1987 > URL: https://issues.apache.org/jira/browse/PHOENIX-1987 > Project: Phoenix > Issue Type: Sub-task > Reporter: James Taylor > Assignee: Shuxiong Ye > Fix For: 5.0.0, 4.5.0, 4.4.1 > > Attachments: 0001-PHOENIX-1987-SIGN-built-in-function-should-be-order_v2.patch, 0001-PHOENIX-1987-fixing-getKeyFormationTraversalIndex-in-SIGN-function.patch > > > The SIGN built-in function preserves the order of its input. This needs to be explicitly implemented in SignFunction by implementing the following method: > {code} > public OrderPreserving preservesOrder() { > return OrderPreserving.YES; > } > {code} > This will allow certain optimizations reducing the amount of memory and/or buffering that is required if SIGN is used in a GROUP BY or ORDER BY clause. -- This message was sent by Atlassian JIRA (v6.3.4#6332)