Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0EF4117C6A for ; Wed, 3 Jun 2015 00:33:32 +0000 (UTC) Received: (qmail 95139 invoked by uid 500); 2 Jun 2015 21:46:52 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 95076 invoked by uid 500); 2 Jun 2015 21:46:52 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 95065 invoked by uid 99); 2 Jun 2015 21:46:52 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 21:46:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 04091CADDA for ; Tue, 2 Jun 2015 21:46:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.77 X-Spam-Level: * X-Spam-Status: No, score=1.77 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id D3TJmMlmf3sQ for ; Tue, 2 Jun 2015 21:46:50 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 51772428ED for ; Tue, 2 Jun 2015 21:46:50 +0000 (UTC) Received: (qmail 94949 invoked by uid 99); 2 Jun 2015 21:46:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 21:46:49 +0000 Date: Tue, 2 Jun 2015 21:46:49 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-1976) Improve PhoenixDriver registration when addShutdownHook fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-1976?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14= 569825#comment-14569825 ]=20 Nick Dimiduk commented on PHOENIX-1976: --------------------------------------- This looks like bad news. FYI [~enis], [~chrajeshbabu32@gmail.com]. >From this build, https://builds.apache.org/job/Phoenix-4.4-HBase-1.1/13/ {noformat} Running org.apache.phoenix.pig.PhoenixHBaseStorerIT Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 13.694 sec = <<< FAILURE! - in org.apache.phoenix.pig.PhoenixHBaseStorerIT org.apache.phoenix.pig.PhoenixHBaseStorerIT Time elapsed: 3.144 sec <<< E= RROR! org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.NoClassDefFoundErr= or: org/apache/hadoop/hbase/protobuf/generated/MasterProtos$DisableTableReq= uest$1 at org.apache.hadoop.hbase.client.RpcRetryingCaller.translateExcept= ion(RpcRetryingCaller.java:229) at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries= (RpcRetryingCaller.java:140) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseA= dmin.java:3917) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTableAsyncV2(HB= aseAdmin.java:1240) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmi= n.java:1199) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmi= n.java:1217) at org.apache.phoenix.query.BaseTest.disableAndDropNonSystemTables(= BaseTest.java:1637) at org.apache.phoenix.query.BaseTest.dropNonSystemTables(BaseTest.j= ava:518) at org.apache.phoenix.end2end.BaseHBaseManagedTimeIT.doTeardown(Bas= eHBaseManagedTimeIT.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessor= Impl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethod= AccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Fram= eworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(Reflecti= veCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(Framew= orkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfte= rs.java:33) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288= ) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createReque= stAndRun(JUnitCoreWrapper.java:107) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy= (JUnitCoreWrapper.java:88) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUn= itCoreWrapper.java:57) at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUn= itCoreProvider.java:144) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSa= meClassLoader(ForkedBooter.java:203) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess= (ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.= java:103) Caused by: java.lang.NoClassDefFoundError: org/apache/hadoop/hbase/protobuf= /generated/MasterProtos$DisableTableRequest$1 at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$DisableT= ableRequest.(MasterProtos.java:12593) at org.apache.hadoop.hbase.protobuf.RequestConverter.buildDisableTa= bleRequest(RequestConverter.java:1211) at org.apache.hadoop.hbase.client.HBaseAdmin$8.call(HBaseAdmin.java= :1245) at org.apache.hadoop.hbase.client.HBaseAdmin$8.call(HBaseAdmin.java= :1241) at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries= (RpcRetryingCaller.java:126) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseA= dmin.java:3917) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTableAsyncV2(HB= aseAdmin.java:1240) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmi= n.java:1199) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmi= n.java:1217) at org.apache.phoenix.query.BaseTest.disableAndDropNonSystemTables(= BaseTest.java:1637) at org.apache.phoenix.query.BaseTest.dropNonSystemTables(BaseTest.j= ava:518) at org.apache.phoenix.end2end.BaseHBaseManagedTimeIT.doTeardown(Bas= eHBaseManagedTimeIT.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessor= Impl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethod= AccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Fram= eworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(Reflecti= veCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(Framew= orkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfte= rs.java:33) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288= ) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createReque= stAndRun(JUnitCoreWrapper.java:107) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy= (JUnitCoreWrapper.java:88) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUn= itCoreWrapper.java:57) at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUn= itCoreProvider.java:144) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSa= meClassLoader(ForkedBooter.java:203) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess= (ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.= java:103) Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.protob= uf.generated.MasterProtos$DisableTableRequest$1 at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$DisableT= ableRequest.(MasterProtos.java:12593) at org.apache.hadoop.hbase.protobuf.RequestConverter.buildDisableTa= bleRequest(RequestConverter.java:1211) at org.apache.hadoop.hbase.client.HBaseAdmin$8.call(HBaseAdmin.java= :1245) at org.apache.hadoop.hbase.client.HBaseAdmin$8.call(HBaseAdmin.java= :1241) at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries= (RpcRetryingCaller.java:126) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseA= dmin.java:3917) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTableAsyncV2(HB= aseAdmin.java:1240) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmi= n.java:1199) at org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmi= n.java:1217) at org.apache.phoenix.query.BaseTest.disableAndDropNonSystemTables(= BaseTest.java:1637) at org.apache.phoenix.query.BaseTest.dropNonSystemTables(BaseTest.j= ava:518) at org.apache.phoenix.end2end.BaseHBaseManagedTimeIT.doTeardown(Bas= eHBaseManagedTimeIT.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessor= Impl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethod= AccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Fram= eworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(Reflecti= veCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(Framew= orkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfte= rs.java:33) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288= ) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createReque= stAndRun(JUnitCoreWrapper.java:107) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy= (JUnitCoreWrapper.java:88) at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUn= itCoreWrapper.java:57) at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUn= itCoreProvider.java:144) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSa= meClassLoader(ForkedBooter.java:203) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess= (ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.= java:103) Results : Tests in error: PhoenixHBaseStorerIT>BaseHBaseManagedTimeIT.doTeardown:59->BaseTest.dropN= onSystemTables:518->BaseTest.disableAndDropNonSystemTables:1637 =C2=BB DoNo= tRetryIO {noformat} > Improve PhoenixDriver registration when addShutdownHook fails > ------------------------------------------------------------- > > Key: PHOENIX-1976 > URL: https://issues.apache.org/jira/browse/PHOENIX-1976 > Project: Phoenix > Issue Type: Bug > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Minor > Fix For: 5.0.0, 4.5.0, 4.4.1 > > Attachments: PHOENIX-1976-master.patch > > > Noticed this in running some tests. RegionServer was shutting down and Me= taDataRegionObserver was just invoking {{postOpen}} > When the {{Class.forName(PhoenixDriver.class.getName())}} gets called, th= e static initializer in {{PhoenixDriver}} gets invoked. Because the RegionS= erver is already stopping, the {{addShutdownHook}} fails with an {{IllegalA= rgumentException}}. > It's not a _huge_ concern because we know the JVM is going down, but ther= e are a few things we could handle better: > * Ensure the PhoenixDriver gets closed if the shutdown hook fails to regi= ster > * Avoid registering the PhoenixDriver instance if we're shutting down -- This message was sent by Atlassian JIRA (v6.3.4#6332)