phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2022) BaseRegionScanner.next should be abstract
Date Mon, 01 Jun 2015 14:49:17 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567385#comment-14567385
] 

James Taylor commented on PHOENIX-2022:
---------------------------------------

+1. This was my thinking as well. Thanks for the patch.

> BaseRegionScanner.next should be abstract
> -----------------------------------------
>
>                 Key: PHOENIX-2022
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2022
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>         Attachments: PHOENIX-2022.patch
>
>
> As pointed out by Yuhao Bi on a [dev list mail|http://s.apache.org/y6b], BaseRegionScanner
implements next as a recursive call to itself. 
> All current subclasses of BaseRegionScanner implement next, but as soon as there is an
implementation that doesn't do this, it will end up with a stack overflow.
> Easy fix is to make this method abstract instead of having a default recursive implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message