phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2018) Implement math build-in function SQRT
Date Thu, 04 Jun 2015 07:00:49 GMT


James Taylor commented on PHOENIX-2018:

bq. What's more, I add one abstract class, JavaMathOneArgumentFunction, as base class for
all one-argument math build-in function.
That's a good idea - that'll make it easier to implement the bulk of these.

bq. SqrtFunction is OrderPreserving.YES, so its result should be the same as input.
That's why I specialize the getSortOrder() method and coerce the result of Math.sqrt here.
You don't need to preserve the sort order if OrderPreserving is YES. Phoenix will still do
the optimization using a reverse scan if the sort order is different. There's really no advantage
to maintaining the sort order. We only do this if we can do it in-place without allocating
more memory for the transformation (for example, with lpad and rpad).

> Implement math build-in function SQRT
> -------------------------------------
>                 Key: PHOENIX-2018
>                 URL:
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Shuxiong Ye
>            Assignee: Shuxiong Ye
>             Fix For: 5.0.0, 4.5.0, 4.4.1
>         Attachments: 0001-PHOENIX-2018-Implement-math-build-in-function-SQRT_v3.patch,
> # SQRT means square root.
> # Return type will be PDouble
> # OrderPreserving

This message was sent by Atlassian JIRA

View raw message