phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-1976) Improve PhoenixDriver registration when addShutdownHook fails
Date Mon, 01 Jun 2015 19:14:17 GMT


Josh Elser commented on PHOENIX-1976:

LMK if the patch doesn't apply cleanly. Happy to send you a fresh one for 4.x-HBase-1.1 if

> Improve PhoenixDriver registration when addShutdownHook fails
> -------------------------------------------------------------
>                 Key: PHOENIX-1976
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 5.0.0, 4.5.0
>         Attachments: PHOENIX-1976-master.patch
> Noticed this in running some tests. RegionServer was shutting down and MetaDataRegionObserver
was just invoking {{postOpen}}
> When the {{Class.forName(PhoenixDriver.class.getName())}} gets called, the static initializer
in {{PhoenixDriver}} gets invoked. Because the RegionServer is already stopping, the {{addShutdownHook}}
fails with an {{IllegalArgumentException}}.
> It's not a _huge_ concern because we know the JVM is going down, but there are a few
things we could handle better:
> * Ensure the PhoenixDriver gets closed if the shutdown hook fails to register
> * Avoid registering the PhoenixDriver instance if we're shutting down

This message was sent by Atlassian JIRA

View raw message