phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1981) PhoenixHBase Load and Store Funcs should handle all Pig data types
Date Thu, 28 May 2015 04:17:17 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562270#comment-14562270
] 

ASF GitHub Bot commented on PHOENIX-1981:
-----------------------------------------

Github user elilevine commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/85#discussion_r31202144
  
    --- Diff: phoenix-pig/src/test/java/org/apache/phoenix/pig/util/TypeUtilTest.java ---
    @@ -0,0 +1,70 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.pig.util;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.when;
    +
    +import java.math.BigDecimal;
    +import java.math.BigInteger;
    +import java.util.List;
    +
    +import org.apache.phoenix.pig.writable.PhoenixPigDBWritable;
    +import org.apache.pig.ResourceSchema.ResourceFieldSchema;
    +import org.apache.pig.data.DataType;
    +import org.apache.pig.data.Tuple;
    +import org.junit.Test;
    +
    +import com.google.common.collect.Lists;
    +
    +public class TypeUtilTest {
    +
    +    @Test
    +    public void testTransformToTuple() throws Exception {
    +        PhoenixPigDBWritable record = mock(PhoenixPigDBWritable.class);
    +        List<Object> values = Lists.newArrayList();
    +        values.add("213123");
    +        values.add(1231123);
    +        values.add(31231231232131L);
    +        values.add("bytearray".getBytes());
    +        when(record.getValues()).thenReturn(values);
    +
    +        ResourceFieldSchema field = new ResourceFieldSchema().setType(DataType.CHARARRAY);
    --- End diff --
    
    I'm cool with the changes. @JamesRTaylor, @jyates you OK to check this in? I'm happy to
commit.


> PhoenixHBase Load and Store Funcs should handle all Pig data types
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-1981
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1981
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Prashant Kommireddi
>            Assignee: Prashant Kommireddi
>
> The load and store func (Pig integration) currently do not handle all Pig types. Here
is a complete list http://pig.apache.org/docs/r0.13.0/basic.html#data-types
> In addition to handling all simple types (BigInteger and BigDecimal are missing in the
LoadFunc currently), we should also look into handling complex Pig types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message